Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove local issue templates. #428

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Remove local issue templates. #428

merged 1 commit into from
Feb 27, 2023

Conversation

hjoliver
Copy link
Member

@hjoliver hjoliver commented Feb 27, 2023 •
edited
Loading

These changes partially address cylc/cylc-admin#127

Companion of https://github.com/cylc/cylc-flow/pull/5365/files

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Any dependency changes applied to setup.cfg.
  • Does not need tests (why?).
  • No change log entry required (why? e.g. invisible to users).
  • No documentation update required.

@hjoliver hjoliver added the small label Feb 27, 2023
@hjoliver hjoliver added this to the 1.3.0 milestone Feb 27, 2023
@hjoliver hjoliver self-assigned this Feb 27, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2023 •
edited
Loading

Codecov Report

Base: 78.93% // Head: 78.93% // No change to project coverage 👍

Coverage data is based on head (faaacdb) compared to base (a8aa020).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #428   +/-   ##
=======================================
  Coverage   78.93%   78.93%           
=======================================
  Files          12       12           
  Lines        1296     1296           
  Branches      218      218           
=======================================
  Hits         1023     1023           
  Misses        230      230           
  Partials       43       43
Impacted Files Coverage Δ
cylc/uiserver/app.py 85.24% <0.00%> (ø)
cylc/uiserver/scripts/gui.py 87.50% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hjoliver hjoliver mentioned this pull request Feb 27, 2023
Merged
6 tasks
@oliver-sanders oliver-sanders modified the milestones: 1.3.0, 1.2.2 Feb 27, 2023
@oliver-sanders oliver-sanders merged commit 3330971 into cylc:master Feb 27, 2023
@wxtim wxtim mentioned this pull request Feb 27, 2023
Merged
6 tasks
@hjoliver hjoliver deleted the remove-issue-templates branch February 27, 2023 21:11
@MetRonnie MetRonnie added the infrastructure GH Actions etc. label Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliver-sanders oliver-sanders oliver-sanders approved these changes

Assignees

@hjoliver hjoliver

Labels
infrastructure GH Actions etc. small
Projects
None yet
Milestone
1.2.2
Development

Successfully merging this pull request may close these issues.
4 participants
@hjoliver @codecov-commenter @oliver-sanders @MetRonnie